Return-Path: X-Original-To: apmail-tez-issues-archive@minotaur.apache.org Delivered-To: apmail-tez-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B54CB181F7 for ; Mon, 22 Feb 2016 19:03:52 +0000 (UTC) Received: (qmail 57511 invoked by uid 500); 22 Feb 2016 19:03:18 -0000 Delivered-To: apmail-tez-issues-archive@tez.apache.org Received: (qmail 57456 invoked by uid 500); 22 Feb 2016 19:03:18 -0000 Mailing-List: contact issues-help@tez.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tez.apache.org Delivered-To: mailing list issues@tez.apache.org Received: (qmail 57404 invoked by uid 99); 22 Feb 2016 19:03:18 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Feb 2016 19:03:18 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 2F8E82C1F60 for ; Mon, 22 Feb 2016 19:03:18 +0000 (UTC) Date: Mon, 22 Feb 2016 19:03:18 +0000 (UTC) From: "Hitesh Shah (JIRA)" To: issues@tez.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TEZ-3131) Support a way to override test_root_dir for FaultToleranceTestRunner MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TEZ-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157490#comment-15157490 ] Hitesh Shah commented on TEZ-3131: ---------------------------------- bq. The string value of the config name is atypical of config names - e.g. tez.test.root-dir. Perhaps something similar could be made available in a common place for all tests with similar logic. Most other tests actually just use the staging dir as is instead of overridding it ( unless it is being overridden for an instance specific sub-dir of the base staging dir). Also, TEST_ROOT_DIR is commonly used to denote ./target/ for unit tests and never really used for a path on DFS when running an end-to-end job test. I went with TEST_ROOT_DIR as that is a similar approach used in TestOrderedWordCount for override params mainly for testing purposes. I can make the property name change to something such as "tez.test-fault-tolerance.staging-dir" ( default value being ./tmp ). Would that work? > Support a way to override test_root_dir for FaultToleranceTestRunner > -------------------------------------------------------------------- > > Key: TEZ-3131 > URL: https://issues.apache.org/jira/browse/TEZ-3131 > Project: Apache Tez > Issue Type: Bug > Reporter: Hitesh Shah > Assignee: Hitesh Shah > Priority: Minor > Attachments: TEZ-3131.1.patch > > > The path is hardcoded. For regression testing, it will be useful if it can be overridden via command-line if needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)