Return-Path: X-Original-To: apmail-tez-issues-archive@minotaur.apache.org Delivered-To: apmail-tez-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 800471871F for ; Fri, 26 Feb 2016 19:47:34 +0000 (UTC) Received: (qmail 9129 invoked by uid 500); 26 Feb 2016 19:47:18 -0000 Delivered-To: apmail-tez-issues-archive@tez.apache.org Received: (qmail 8843 invoked by uid 500); 26 Feb 2016 19:47:18 -0000 Mailing-List: contact issues-help@tez.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tez.apache.org Delivered-To: mailing list issues@tez.apache.org Received: (qmail 8794 invoked by uid 99); 26 Feb 2016 19:47:18 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Feb 2016 19:47:18 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 214542C1F56 for ; Fri, 26 Feb 2016 19:47:18 +0000 (UTC) Date: Fri, 26 Feb 2016 19:47:18 +0000 (UTC) From: "Jason Lowe (JIRA)" To: issues@tez.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TEZ-1911) MergeManager's unconditionalReserve() should check for memory limits before allocating memory to IntermediateMemoryToMemoryMerger MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TEZ-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169646#comment-15169646 ] Jason Lowe commented on TEZ-1911: --------------------------------- I'll hold off on the cherry-pick to branch-0.7 until the findbugs issue is resolved in master. > MergeManager's unconditionalReserve() should check for memory limits before allocating memory to IntermediateMemoryToMemoryMerger > --------------------------------------------------------------------------------------------------------------------------------- > > Key: TEZ-1911 > URL: https://issues.apache.org/jira/browse/TEZ-1911 > Project: Apache Tez > Issue Type: Bug > Reporter: Rajesh Balamohan > Assignee: Rajesh Balamohan > Fix For: 0.8.3 > > Attachments: TEZ-1911.1.patch, TEZ-1911.2.patch, TEZ-1911.3.patch > > > Currently, IntermediateMemoryToMemoryMerger invokes unconditionalReserve() to get the memory needed for intermediate mem-to-mem merging. It could potentially cause issue in the following scenario > 1. tez.runtime.io.sort.factor set to 100 and assume shuffled data (e.g 60% memory occupied) haven't reached TEZ_RUNTIME_SHUFFLE_MERGE_PERCENT_DEFAULT > 2. Assume that it reaches the sort.factor threshold before reaching merge threshold. This would kick in IntermediateMemoryToMemoryMerger. > In IntermediateMemoryToMemoryMerger, it would try to allocate additional 60% without any boundary checks. This could lead to OOM depending on the tez.runtime.io.sort.mb setting. -- This message was sent by Atlassian JIRA (v6.3.4#6332)