tez-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hitesh Shah (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEZ-3131) Support a way to override test_root_dir for FaultToleranceTestRunner
Date Mon, 22 Feb 2016 19:03:18 GMT

    [ https://issues.apache.org/jira/browse/TEZ-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157490#comment-15157490
] 

Hitesh Shah commented on TEZ-3131:
----------------------------------

bq. The string value of the config name is atypical of config names - e.g. tez.test.root-dir.
Perhaps something similar could be made available in a common place for all tests with similar
logic.

Most other tests actually just use the staging dir as is instead of overridding it ( unless
it is being overridden for an instance specific sub-dir of the base staging dir). Also, TEST_ROOT_DIR
is commonly used to denote ./target/ for unit tests and never really used for a path on DFS
when running an end-to-end job test. 

I went with TEST_ROOT_DIR as that is a similar approach used in TestOrderedWordCount for override
params mainly for testing purposes. I can make the property name change to something such
as "tez.test-fault-tolerance.staging-dir" ( default value being ./tmp ). Would that work?



> Support a way to override test_root_dir for FaultToleranceTestRunner
> --------------------------------------------------------------------
>
>                 Key: TEZ-3131
>                 URL: https://issues.apache.org/jira/browse/TEZ-3131
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Hitesh Shah
>            Assignee: Hitesh Shah
>            Priority: Minor
>         Attachments: TEZ-3131.1.patch
>
>
> The path is hardcoded. For regression testing, it will be useful if it can be overridden
via command-line if needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message