Return-Path: X-Original-To: apmail-tez-issues-archive@minotaur.apache.org Delivered-To: apmail-tez-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E9E39188DD for ; Tue, 14 Jul 2015 21:49:04 +0000 (UTC) Received: (qmail 84254 invoked by uid 500); 14 Jul 2015 21:49:04 -0000 Delivered-To: apmail-tez-issues-archive@tez.apache.org Received: (qmail 84090 invoked by uid 500); 14 Jul 2015 21:49:04 -0000 Mailing-List: contact issues-help@tez.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tez.apache.org Delivered-To: mailing list issues@tez.apache.org Received: (qmail 83914 invoked by uid 99); 14 Jul 2015 21:49:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Jul 2015 21:49:04 +0000 Date: Tue, 14 Jul 2015 21:49:04 +0000 (UTC) From: "Saikat (JIRA)" To: issues@tez.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (TEZ-2613) Fetcher(unordered) using List to store InputAttemptIdentifier can lead to some inefficiency during remove() operation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TEZ-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627099#comment-14627099 ] Saikat edited comment on TEZ-2613 at 7/14/15 9:48 PM: ------------------------------------------------------ changes: 1. keep one remaining list instead of two srcAttempts and remaining list.(doubt:why do we need 2 list?) 2. Make a subclass InputAttemptIndentiferWithSpills which overrides the hashcode and equals method. 3. Make a custom wrapper InputAttemptIndentiferList class to encapsulate differnt types of InputAttemptIdentifier objects 4. Test cases for the InputAttemptIndentiferList If this patch is accepted, similar changes can be made to Ordered Fetchers. was (Author: saikatr): changes: 1. keep one remaining list instead of two srcAttempts and remaining list.(doubt:why do we need 2 list?) 2. Make a subclass InputAttemptIndentiferWithSpills which overrides the hashcode and equals method. 3. Make a custom wrapper InputAttemptIndentiferList class to encapsulate differnt types of InputAttemptIdentifier objects 4. Test cases for the InputAttemptIndentiferList > Fetcher(unordered) using List to store InputAttemptIdentifier can lead to some inefficiency during remove() operation > --------------------------------------------------------------------------------------------------------------------- > > Key: TEZ-2613 > URL: https://issues.apache.org/jira/browse/TEZ-2613 > Project: Apache Tez > Issue Type: Improvement > Reporter: Saikat > Assignee: Saikat > Attachments: TEZ-2613.patch > > > remove() operation on the remaining list can be inefficient. -- This message was sent by Atlassian JIRA (v6.3.4#6332)