tez-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Siddharth Seth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEZ-2608) UnorderedPartitionedKVWriter should override write(Object key, Iterable<Object> values)
Date Tue, 14 Jul 2015 15:53:04 GMT

    [ https://issues.apache.org/jira/browse/TEZ-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14626536#comment-14626536
] 

Siddharth Seth commented on TEZ-2608:
-------------------------------------

[~ozawa] - I think this will need some more checks. Sending in IFile.RepeatKey would primarily
be useful when writing directly to Ifiles (skipping the buffers). When the buffers are not
skipped - the patch will likely have issues.
Another useful bit to look at is whether the write(Key, Iterable<Values) API can be used
in any of the actual writers. Currently it's only exercised by tests.

> UnorderedPartitionedKVWriter should override write(Object key, Iterable<Object>
values) 
> ----------------------------------------------------------------------------------------
>
>                 Key: TEZ-2608
>                 URL: https://issues.apache.org/jira/browse/TEZ-2608
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Tsuyoshi Ozawa
>            Assignee: Tsuyoshi Ozawa
>         Attachments: TEZ-2608.001.patch
>
>
> From BaseUnorderedPartitionedKVWriter:
> {code}
>   @Override
>   public void write(Object key, Iterable<Object> values) throws IOException {
>     //TODO: UnorderedPartitionedKVWriter should override this method later.
>     Iterator<Object> it = values.iterator();
>     while(it.hasNext()) {
>       write(key, it.next());
>     }
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message