tez-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rajesh Balamohan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEZ-2575) Handle KeyValue pairs size which do not fit in a single block
Date Thu, 02 Jul 2015 22:44:05 GMT

    [ https://issues.apache.org/jira/browse/TEZ-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612636#comment-14612636

Rajesh Balamohan commented on TEZ-2575:

lgtm. Thanks [~saikatr]. 

One very minor comment
- "conf.setBoolean(TezRuntimeConfiguration.TEZ_RUNTIME_ENABLE_FINAL_MERGE_IN_OUTPUT, false);"
has to be reset to false after testExceedsKVWithMultiplePartitions(). Otherwise other tests
could be running with the same setting.  Sorry, should have caught this in earlier patch.

> Handle KeyValue pairs size which do not fit in a single block
> -------------------------------------------------------------
>                 Key: TEZ-2575
>                 URL: https://issues.apache.org/jira/browse/TEZ-2575
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Saikat
>            Assignee: Saikat
>         Attachments: TEZ-2575.1.patch, TEZ-2575.2.patch, TEZ-2575.3.patch, TEZ-2575.patch
> In the present implementation, the available buffer is divided into blocks (specified
in the constructor for pipeline sort). and a linked list of these block byte buffers is maintained.

> A span is created out of the buffers. 
> The present logic, doesnot handle scenario where a single key-value pair size doesnot
fit into any of the blocks.
> example if 1mb total memory is divided into 4 blocks, (256 kb each),
> if a single KV pair is greater than the blocksize(~ignoring meta data size), 
> then it fails with buffer exceptions.

This message was sent by Atlassian JIRA

View raw message