tez-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chang Li (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (TEZ-900) Confusing message for incorrect queue for some tez examples
Date Tue, 03 Feb 2015 23:10:35 GMT

    [ https://issues.apache.org/jira/browse/TEZ-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304269#comment-14304269
] 

Chang Li edited comment on TEZ-900 at 2/3/15 11:10 PM:
-------------------------------------------------------

[~hitesh] YarnClientImpl's check isn't complete. The "failure of submit to the wrong queue"
doesn't really fail to be submitted, instead it succeed in being submitted, however failed
immediately after. The check in YarnClientImpl is simply 
{code}
         if (!state.equals(YarnApplicationState.NEW) &&
            !state.equals(YarnApplicationState.NEW_SAVING)) {
          LOG.info("Submitted application " + applicationId);
          break;
        }
{code} 
because the state at that time is now FAILED, it will break out the loop and not be captured
within YarnClient. But YarnRunner did a more thorough check, it did check FAILED and KILLED
state immediate after launch,
{code}
     if (appMaster == null
          || appMaster.getYarnApplicationState() == YarnApplicationState.FAILED
          || appMaster.getYarnApplicationState() == YarnApplicationState.KILLED) {
        throw new IOException("Failed to run job : " +
            diagnostics);
      }
{code}
I can open a jira on yarn for this issue, and I think the solution is simply duplicating the
check logic from YarnRunner to YarnClient


was (Author: lichangleo):
[~hitesh] YarnClientImpl's check isn't complete. The "failure of submit to the wrong queue"
doesn't really fail to be submitted, instead it succeed in being submitted, however failed
immediately after. The check in YarnClientImpl is simply 
         "if (!state.equals(YarnApplicationState.NEW) &&
            !state.equals(YarnApplicationState.NEW_SAVING)) {
          LOG.info("Submitted application " + applicationId);
          break;
        }" 
because the state at that time is now FAILED, it will break out the loop and not be captured
within YarnClient. But YarnRunner did a more thorough check, it did check FAILED and KILLED
state immediate after launch,
     "if (appMaster == null
          || appMaster.getYarnApplicationState() == YarnApplicationState.FAILED
          || appMaster.getYarnApplicationState() == YarnApplicationState.KILLED) {
        throw new IOException("Failed to run job : " +
            diagnostics);
      }"
I can open a jira on yarn for this issue, and I think the solution is simply duplicating the
check logic from YarnRunner to YarnClient

> Confusing message for incorrect queue for some tez examples
> -----------------------------------------------------------
>
>                 Key: TEZ-900
>                 URL: https://issues.apache.org/jira/browse/TEZ-900
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.3.0
>            Reporter: Jonathan Eagles
>            Assignee: Chang Li
>         Attachments: tez900.patch
>
>
> The error message of at least orderedwordcount with non-existent queue is very difficult
as compared to mrrsleep which is very intuitive.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message