Return-Path: X-Original-To: apmail-tez-issues-archive@minotaur.apache.org Delivered-To: apmail-tez-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 52EA417FF7 for ; Wed, 22 Oct 2014 07:48:34 +0000 (UTC) Received: (qmail 75529 invoked by uid 500); 22 Oct 2014 07:48:34 -0000 Delivered-To: apmail-tez-issues-archive@tez.apache.org Received: (qmail 75469 invoked by uid 500); 22 Oct 2014 07:48:34 -0000 Mailing-List: contact issues-help@tez.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tez.apache.org Delivered-To: mailing list issues@tez.apache.org Received: (qmail 75457 invoked by uid 99); 22 Oct 2014 07:48:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Oct 2014 07:48:34 +0000 Date: Wed, 22 Oct 2014 07:48:33 +0000 (UTC) From: "Gopal V (JIRA)" To: issues@tez.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (TEZ-1593) Refactor PipelinedSorter to remove all MMAP based ByteBuffer references MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TEZ-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gopal V updated TEZ-1593: ------------------------- Attachment: TEZ-1593.1.patch > Refactor PipelinedSorter to remove all MMAP based ByteBuffer references > ----------------------------------------------------------------------- > > Key: TEZ-1593 > URL: https://issues.apache.org/jira/browse/TEZ-1593 > Project: Apache Tez > Issue Type: Bug > Affects Versions: 0.6.0 > Reporter: Gopal V > Assignee: Gopal V > Labels: Performance > Attachments: TEZ-1593.1.patch > > > The current implementation of PipelinedSorter has a slow section which revolves around key comparisons - this was relevant when the implementation used direct byte buffers to back the kvbuffer. > {code} > kvbuffer.position(istart); > kvbuffer.get(ki, 0, ilen); > kvbuffer.position(jstart); > kvbuffer.get(kj, 0, jlen); > // sort by key > final int cmp = comparator.compare(ki, 0, ilen, kj, 0, jlen); > {code} > The kvbuffer.get into the arrays ki and kj are the slowest part of the comparator operation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)