Mailing-List: contact issues-help@tez.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tez.apache.org
Date: Tue, 21 Oct 2014 22:21:33 +0000 (UTC)
From: "Siddharth Seth (JIRA)" <jira@apache.org>
To: issues@tez.apache.org
Message-ID: <JIRA.12734283.1408055746000.310138.1413930093639@Atlassian.JIRA>
In-Reply-To: <JIRA.12734283.1408055746000@Atlassian.JIRA>
References: <JIRA.12734283.1408055746000@Atlassian.JIRA>
 <JIRA.12734283.1408055746698@arcas>
Subject: [jira] [Commented] (TEZ-1424) Fixes to DAG text representation in
 debug mode
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/TEZ-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14179224#comment-14179224 ] 

Siddharth Seth commented on TEZ-1424:
-------------------------------------

- Javadocs for TEZ_GENERATE_DEBUG_ARTIFACTS - to reflect the text plan being logged rather than the dag visualization.
bq. Patch uses DAG_ID in the filename for correlating filename with the DAG. If we have to use DagPlan, we need to provide some unique number in the filename.
Can we log this at the same place wher the dag visualization is generated in that case. That's before any signal is sent to start the DAG - which would make it less prone to being logeed after a potential failure.
- In getCredentialsInfo, along with the service - it'd be useful to log the KIND as well.
- TextFormat.printField(entry.getKey(), entry.getValue(), sb); - this handles logging of fields a little better - with the name of the field getting logged correctly.
Also, credentials checking, instead of comparing the object, can be done using PB artifacts itself
{code}if (descriptor.getNumber() != DAGProtos.DAGPlan.CREDENTIALS_BINARY_FIELD_NUMBER) {{code}


> Fixes to DAG text representation in debug mode
> ----------------------------------------------
>
>                 Key: TEZ-1424
>                 URL: https://issues.apache.org/jira/browse/TEZ-1424
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Siddharth Seth
>            Assignee: Rajesh Balamohan
>            Priority: Critical
>         Attachments: TEZ-1424.1.patch, TEZ-1424.2.patch
>
>
> Several fixes required
> - Don't log entire tokens, just the identifier should be enough
> - DAG ID (or unique number needs to be used). Otherwise we get only one file per session
> - This should not go into the local-directory - since that isn't accessible. Instead the log directory would be a better place.
> Marking as critical for 0.5.1 since this is very useful for debugging.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)