Return-Path: X-Original-To: apmail-tez-issues-archive@minotaur.apache.org Delivered-To: apmail-tez-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 04E9D17915 for ; Wed, 22 Oct 2014 18:36:34 +0000 (UTC) Received: (qmail 95967 invoked by uid 500); 22 Oct 2014 18:36:33 -0000 Delivered-To: apmail-tez-issues-archive@tez.apache.org Received: (qmail 95915 invoked by uid 500); 22 Oct 2014 18:36:33 -0000 Mailing-List: contact issues-help@tez.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tez.apache.org Delivered-To: mailing list issues@tez.apache.org Received: (qmail 95905 invoked by uid 99); 22 Oct 2014 18:36:33 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Oct 2014 18:36:33 +0000 Date: Wed, 22 Oct 2014 18:36:33 +0000 (UTC) From: "Bikas Saha (JIRA)" To: issues@tez.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TEZ-1359) SimpleMRProcessor commit should handle IO/Interrupted exceptions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TEZ-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14180293#comment-14180293 ] Bikas Saha commented on TEZ-1359: --------------------------------- I just looked at the code in the project when I tried to apply the patch. It looks like it has already been updated to catch IOExceptions and it seems IO exceptions should not be retried by us because we dont know what exactly the real commit user code is doing. We could have handled interrupted exception via this patch, but we recently decided not to catch interrupted exceptions in the task execution and instead let them bubble to the top. Given the above I am going to resolve this jira as wont-fix. I should have done this earlier so that your time would not have been wasted in creating the patch. I am sorry about that. Please consider contributing to some other jiras. Your help is much appreciated. > SimpleMRProcessor commit should handle IO/Interrupted exceptions > ---------------------------------------------------------------- > > Key: TEZ-1359 > URL: https://issues.apache.org/jira/browse/TEZ-1359 > Project: Apache Tez > Issue Type: Bug > Affects Versions: 0.6.0 > Reporter: Bikas Saha > Labels: newbie > Attachments: TEZ-1359-20141021.patch, TEZ-1359-20141022.patch > > > The commit should have some retries against RPC IO exceptions. Interrupted exceptions should abort() and complete. -- This message was sent by Atlassian JIRA (v6.3.4#6332)