From dev-return-2172-archive-asf-public=cust-asf.ponee.io@tephra.incubator.apache.org Tue May 8 02:40:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3BABB180648 for ; Tue, 8 May 2018 02:40:03 +0200 (CEST) Received: (qmail 68245 invoked by uid 500); 8 May 2018 00:40:02 -0000 Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tephra.incubator.apache.org Delivered-To: mailing list dev@tephra.incubator.apache.org Received: (qmail 68229 invoked by uid 99); 8 May 2018 00:40:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 May 2018 00:40:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id EE67A1A2C92 for ; Tue, 8 May 2018 00:40:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -102.311 X-Spam-Level: X-Spam-Status: No, score=-102.311 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id AXDbwk1CEm_Q for ; Tue, 8 May 2018 00:40:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 152D65F4E4 for ; Tue, 8 May 2018 00:40:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8C7AEE026E for ; Tue, 8 May 2018 00:40:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4A57021296 for ; Tue, 8 May 2018 00:40:00 +0000 (UTC) Date: Tue, 8 May 2018 00:40:00 +0000 (UTC) From: "James Taylor (JIRA)" To: dev@tephra.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TEPHRA-287) ActionChange.getChangeKey() not implemented correctly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TEPHRA-287?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1646= 6682#comment-16466682 ]=20 James Taylor commented on TEPHRA-287: ------------------------------------- Thanks for the review, [~poornachandra]. I made your recommended changes an= d=C2=A0merged the change. > ActionChange.getChangeKey() not implemented correctly > ----------------------------------------------------- > > Key: TEPHRA-287 > URL: https://issues.apache.org/jira/browse/TEPHRA-287 > Project: Tephra > Issue Type: Bug > Reporter: James Taylor > Assignee: James Taylor > Priority: Major > Fix For: 0.14.0-incubating > > Attachments: TEPHRA-287_v1.patch, TEPHRA-287_v2.patch, TEPHRA-287= _v3.patch > > > The ActionChange.getChangeKey() simply concatenates together the row key,= family, and qualifier which could lead to incorrect conflicting keys. For = example (rowKey=3D'a', family=3D'bc') would conflict with (rowKey=3D'ab', f= amily=3D'c'). A simple fix would be to prefix each part with the byte lengt= h of each part. -- This message was sent by Atlassian JIRA (v7.6.3#76005)