tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Poorna Chandra (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEPHRA-287) ActionChange.getChangeKey() not implemented correctly
Date Mon, 07 May 2018 03:52:00 GMT

    [ https://issues.apache.org/jira/browse/TEPHRA-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465405#comment-16465405

Poorna Chandra commented on TEPHRA-287:

[~jamestaylor] The changes look good to me. I have a couple of minor comments. You can merge
the changes after fixing them.

> ActionChange.getChangeKey() not implemented correctly
> -----------------------------------------------------
>                 Key: TEPHRA-287
>                 URL: https://issues.apache.org/jira/browse/TEPHRA-287
>             Project: Tephra
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>            Priority: Major
>             Fix For: 0.14.0-incubating
>         Attachments: TEPHRA-287_v1.patch, TEPHRA-287_v2.patch, TEPHRA-287_v3.patch
> The ActionChange.getChangeKey() simply concatenates together the row key, family, and
qualifier which could lead to incorrect conflicting keys. For example (rowKey='a', family='bc')
would conflict with (rowKey='ab', family='c'). A simple fix would be to prefix each part with
the byte length of each part.

This message was sent by Atlassian JIRA

View raw message