From dev-return-2095-archive-asf-public=cust-asf.ponee.io@tephra.incubator.apache.org Thu Apr 5 20:42:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9E7CC180771 for ; Thu, 5 Apr 2018 20:42:04 +0200 (CEST) Received: (qmail 89546 invoked by uid 500); 5 Apr 2018 18:42:03 -0000 Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tephra.incubator.apache.org Delivered-To: mailing list dev@tephra.incubator.apache.org Received: (qmail 89531 invoked by uid 99); 5 Apr 2018 18:42:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Apr 2018 18:42:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C35701A1675 for ; Thu, 5 Apr 2018 18:42:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id GKfRDFlQwY1x for ; Thu, 5 Apr 2018 18:42:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id DA1EE5F4DC for ; Thu, 5 Apr 2018 18:42:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DD089E09EB for ; Thu, 5 Apr 2018 18:42:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4DD7825625 for ; Thu, 5 Apr 2018 18:42:00 +0000 (UTC) Date: Thu, 5 Apr 2018 18:42:00 +0000 (UTC) From: "James Taylor (JIRA)" To: dev@tephra.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (TEPHRA-287) ActionChange.getChangeKey() not implemented correctly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TEPHRA-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427430#comment-16427430 ] James Taylor edited comment on TEPHRA-287 at 4/5/18 6:41 PM: ------------------------------------------------------------- bq. If all the clients are not upgraded simultaneously then we may miss some conflicts due to the change set encoding change. Any thoughts on how to handle this? Good point. The only thing I can think of would be to have a new config property that enables the new change set encoding. When not set, the old encoding scheme would be used. The config would be enabled only after knowing that all clients have been upgraded. I can implement this if you think it's a reasonable approach. was (Author: jamestaylor): bq. f all the clients are not upgraded simultaneously then we may miss some conflicts due to the change set encoding change. Any thoughts on how to handle this? Good point. The only thing I can think of would be to have a new config property that enables the new change set encoding. When not set, the old encoding scheme would be used. The config would be enabled only after knowing that all clients have been upgraded. I can implement this if you think it's a reasonable approach. > ActionChange.getChangeKey() not implemented correctly > ----------------------------------------------------- > > Key: TEPHRA-287 > URL: https://issues.apache.org/jira/browse/TEPHRA-287 > Project: Tephra > Issue Type: Bug > Reporter: James Taylor > Assignee: James Taylor > Priority: Major > Fix For: 0.14.0-incubating > > Attachments: TEPHRA-287_v1.patch, TEPHRA-287_v2.patch > > > The ActionChange.getChangeKey() simply concatenates together the row key, family, and qualifier which could lead to incorrect conflicting keys. For example (rowKey='a', family='bc') would conflict with (rowKey='ab', family='c'). A simple fix would be to prefix each part with the byte length of each part. -- This message was sent by Atlassian JIRA (v7.6.3#76005)