From dev-return-2114-archive-asf-public=cust-asf.ponee.io@tephra.incubator.apache.org Mon Apr 30 20:30:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DBF03180647 for ; Mon, 30 Apr 2018 20:30:05 +0200 (CEST) Received: (qmail 22361 invoked by uid 500); 30 Apr 2018 18:30:04 -0000 Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tephra.incubator.apache.org Delivered-To: mailing list dev@tephra.incubator.apache.org Received: (qmail 22350 invoked by uid 99); 30 Apr 2018 18:30:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Apr 2018 18:30:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 65C551A04C1 for ; Mon, 30 Apr 2018 18:30:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id gPndN_5zuftD for ; Mon, 30 Apr 2018 18:30:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id ED8DE5FB98 for ; Mon, 30 Apr 2018 18:30:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CCB99E0D74 for ; Mon, 30 Apr 2018 18:30:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3D48B212A0 for ; Mon, 30 Apr 2018 18:30:00 +0000 (UTC) Date: Mon, 30 Apr 2018 18:30:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@tephra.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TEPHRA-270) Avoid transaction state cache refresh on co-procesor startup MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TEPHRA-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458839#comment-16458839 ] ASF GitHub Bot commented on TEPHRA-270: --------------------------------------- Github user poornachandra commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/72#discussion_r185069321 --- Diff: tephra-core/src/main/java/org/apache/tephra/coprocessor/TransactionStateCache.java --- @@ -78,6 +78,7 @@ protected void startUp() throws Exception { protected void shutDown() throws Exception { if (refreshService != null) { refreshService.interrupt(); + refreshService.join(1000); --- End diff -- `Thread.join(long millis)` does not throw an exception on timeout being reached. It only throws `IllegalArgumentException` when timeout is negative or `InterruptedException`. Are you talking about handling the `InterruptedException`? > Avoid transaction state cache refresh on co-procesor startup > ------------------------------------------------------------ > > Key: TEPHRA-270 > URL: https://issues.apache.org/jira/browse/TEPHRA-270 > Project: Tephra > Issue Type: Improvement > Components: core > Reporter: Poorna Chandra > Assignee: Poorna Chandra > Priority: Major > Fix For: 0.14.0-incubating > > > Transaction state cache, on startup, refreshes the transaction snapshot from HDFS. The transaction state cache startup is called during HBase co-processor startup. The refresh of the transaction snapshot can block, thus blocking the co-processor startup. > The subsequent transaction snapshot refreshes happen in the background. Also - there is no guarantee that a snapshot will be present during the refresh on startup. Hence it is okay not to refresh the snapshot during snapshot, but do it in background. -- This message was sent by Atlassian JIRA (v7.6.3#76005)