From dev-return-2099-apmail-tephra-dev-archive=tephra.apache.org@tephra.incubator.apache.org Tue Apr 24 18:29:03 2018 Return-Path: X-Original-To: apmail-tephra-dev-archive@minotaur.apache.org Delivered-To: apmail-tephra-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A685F180E0 for ; Tue, 24 Apr 2018 18:29:03 +0000 (UTC) Received: (qmail 37377 invoked by uid 500); 24 Apr 2018 18:29:03 -0000 Delivered-To: apmail-tephra-dev-archive@tephra.apache.org Received: (qmail 37339 invoked by uid 500); 24 Apr 2018 18:29:03 -0000 Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tephra.incubator.apache.org Delivered-To: mailing list dev@tephra.incubator.apache.org Received: (qmail 37233 invoked by uid 99); 24 Apr 2018 18:29:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Apr 2018 18:29:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id D111A18062F for ; Tue, 24 Apr 2018 18:29:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Qw84fcdUvqXz for ; Tue, 24 Apr 2018 18:29:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 54E275F3CE for ; Tue, 24 Apr 2018 18:29:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AF2C5E0E65 for ; Tue, 24 Apr 2018 18:29:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 69E40241C7 for ; Tue, 24 Apr 2018 18:29:00 +0000 (UTC) Date: Tue, 24 Apr 2018 18:29:00 +0000 (UTC) From: "Poorna Chandra (JIRA)" To: dev@tephra.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TEPHRA-287) ActionChange.getChangeKey() not implemented correctly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TEPHRA-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16450352#comment-16450352 ] Poorna Chandra commented on TEPHRA-287: --------------------------------------- The config is a good idea James. This way we could upgrade the transaction manager first, and then allow the clients to be upgraded later. During the time clients are being upgraded, the transaction manager will accept change sets in both old and new format. Once all the clients are upgraded, we can flip the flag, and the transaction manager will start rejecting the change sets in the old format. > ActionChange.getChangeKey() not implemented correctly > ----------------------------------------------------- > > Key: TEPHRA-287 > URL: https://issues.apache.org/jira/browse/TEPHRA-287 > Project: Tephra > Issue Type: Bug > Reporter: James Taylor > Assignee: James Taylor > Priority: Major > Fix For: 0.14.0-incubating > > Attachments: TEPHRA-287_v1.patch, TEPHRA-287_v2.patch > > > The ActionChange.getChangeKey() simply concatenates together the row key, family, and qualifier which could lead to incorrect conflicting keys. For example (rowKey='a', family='bc') would conflict with (rowKey='ab', family='c'). A simple fix would be to prefix each part with the byte length of each part. -- This message was sent by Atlassian JIRA (v7.6.3#76005)