From dev-return-2093-apmail-tephra-dev-archive=tephra.apache.org@tephra.incubator.apache.org Mon Apr 2 22:51:03 2018 Return-Path: X-Original-To: apmail-tephra-dev-archive@minotaur.apache.org Delivered-To: apmail-tephra-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5EDA118124 for ; Mon, 2 Apr 2018 22:51:03 +0000 (UTC) Received: (qmail 94462 invoked by uid 500); 2 Apr 2018 22:51:03 -0000 Delivered-To: apmail-tephra-dev-archive@tephra.apache.org Received: (qmail 94420 invoked by uid 500); 2 Apr 2018 22:51:03 -0000 Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tephra.incubator.apache.org Delivered-To: mailing list dev@tephra.incubator.apache.org Received: (qmail 94409 invoked by uid 99); 2 Apr 2018 22:51:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Apr 2018 22:51:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id AE1641A1143 for ; Mon, 2 Apr 2018 22:51:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id UI8Nx-gK6U2P for ; Mon, 2 Apr 2018 22:51:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 41BCD5F4AA for ; Mon, 2 Apr 2018 22:51:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7468CE0354 for ; Mon, 2 Apr 2018 22:51:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3109C25611 for ; Mon, 2 Apr 2018 22:51:00 +0000 (UTC) Date: Mon, 2 Apr 2018 22:51:00 +0000 (UTC) From: "Terence Yim (JIRA)" To: dev@tephra.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TEPHRA-269) Protect the Transaction Manager against misconfigured clients using rate limits MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TEPHRA-269?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1642= 3251#comment-16423251 ]=20 Terence Yim commented on TEPHRA-269: ------------------------------------ Thanks for the detailed design. I only have two comments. =C2=A0 # Have we think about how does it work together with tx pruning? Some clie= nts could be generating invalid transaction at a fast rate due to the inval= id tx list size is large (e.g. keep getting out of memory after making the = startTx() call, but unable to hold the tx list from the response), hence ge= tting throttled. In theory, reduction in the tx list size could up lift the= throttle and reduce the operation counts (not necessarily zero) to unblock= the clients. # For the=C2=A0rate limiter API, I think it will be cleaner to have explic= it methods for getting/clearing the rate limits for all clients, instead of= using empty Set as the indicator.=C2=A0 > Protect the Transaction Manager against misconfigured clients using rate = limits > -------------------------------------------------------------------------= ------ > > Key: TEPHRA-269 > URL: https://issues.apache.org/jira/browse/TEPHRA-269 > Project: Tephra > Issue Type: New Feature > Components: core > Reporter: Poorna Chandra > Assignee: Poorna Chandra > Priority: Major > Fix For: 0.14.0-incubating > > Attachments: Ensure QoS in Transaction Manager by rate limiting c= lient requests.pdf > > > We have seen cases where misconfigured clients can overwhelm the system b= y making expensive requests (like invalidating transactions). By the time a= dmins figure out there is a misconfigured client and take corrective action= , thousands of invalid transactions can be created in a very short period o= f time. It would be useful to have a way to limit the number of invalid tra= nsactions that a client can create in given time. > I'll send out a design document for this soon. -- This message was sent by Atlassian JIRA (v7.6.3#76005)