tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEPHRA-267) ReferenceCountedSupplier hangs during release when Error is thrown during startup
Date Thu, 26 Apr 2018 00:17:00 GMT

    [ https://issues.apache.org/jira/browse/TEPHRA-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453273#comment-16453273
] 

ASF GitHub Bot commented on TEPHRA-267:
---------------------------------------

GitHub user poornachandra opened a pull request:

    https://github.com/apache/incubator-tephra/pull/73

    TEPHRA-267 Save the service reference in ReferenceCountedSupplier only if startup is successful

    JIRA - https://issues.apache.org/jira/browse/TEPHRA-267

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/poornachandra/incubator-tephra feature/ref-count-supplier

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tephra/pull/73.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #73
    
----
commit 01f172157eb959f5a2e52d8d7c38f948298f30c1
Author: poorna <poorna@...>
Date:   2018-04-26T00:15:48Z

    TEPHRA-267 Save the service reference in ReferenceCountedSupplier only if startup is successful

----


> ReferenceCountedSupplier hangs during release when Error is thrown during startup
> ---------------------------------------------------------------------------------
>
>                 Key: TEPHRA-267
>                 URL: https://issues.apache.org/jira/browse/TEPHRA-267
>             Project: Tephra
>          Issue Type: Bug
>          Components: core
>            Reporter: Poorna Chandra
>            Assignee: Poorna Chandra
>            Priority: Major
>             Fix For: 0.14.0-incubating
>
>
> ReferenceCountedSupplier saves the reference to the service being started and then starts
it. If the startup throws an Error then the failed service is stored, and then other clients
also use the failed service since the reference is not null. During shutdown, the failed service
will be stopped which can lead to the stop thread hanging (due to Guava not setting the service
in failed state when Error is thrown)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message