tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From poornachandra <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #72: TEPHRA-270 TEPHRA-271 Transaction state c...
Date Mon, 30 Apr 2018 18:29:38 GMT
Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/72#discussion_r185069321
  
    --- Diff: tephra-core/src/main/java/org/apache/tephra/coprocessor/TransactionStateCache.java
---
    @@ -78,6 +78,7 @@ protected void startUp() throws Exception {
       protected void shutDown() throws Exception {
         if (refreshService != null) {
           refreshService.interrupt();
    +      refreshService.join(1000);
    --- End diff --
    
    `Thread.join(long millis)` does not throw an exception on timeout being reached. It only
throws `IllegalArgumentException` when timeout is negative or `InterruptedException`.
    
    Are you talking about handling the `InterruptedException`?


---

Mime
View raw message