tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anew <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #72: TEPHRA-270 TEPHRA-271 Transaction state c...
Date Thu, 26 Apr 2018 09:22:10 GMT
Github user anew commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/72#discussion_r184323707
  
    --- Diff: tephra-core/src/main/java/org/apache/tephra/coprocessor/TransactionStateCache.java
---
    @@ -78,6 +78,7 @@ protected void startUp() throws Exception {
       protected void shutDown() throws Exception {
         if (refreshService != null) {
           refreshService.interrupt();
    +      refreshService.join(1000);
    --- End diff --
    
    this means, if the refreshService does not finish within a second, shutdown() will throw
exception? And the remainder of the shutdown sequence is not performed? Is that intentional?


---

Mime
View raw message