From dev-return-2075-apmail-tephra-dev-archive=tephra.apache.org@tephra.incubator.apache.org Fri Mar 23 21:03:03 2018 Return-Path: X-Original-To: apmail-tephra-dev-archive@minotaur.apache.org Delivered-To: apmail-tephra-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9986817446 for ; Fri, 23 Mar 2018 21:03:03 +0000 (UTC) Received: (qmail 72831 invoked by uid 500); 23 Mar 2018 21:03:03 -0000 Delivered-To: apmail-tephra-dev-archive@tephra.apache.org Received: (qmail 72791 invoked by uid 500); 23 Mar 2018 21:03:03 -0000 Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tephra.incubator.apache.org Delivered-To: mailing list dev@tephra.incubator.apache.org Received: (qmail 72771 invoked by uid 99); 23 Mar 2018 21:03:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Mar 2018 21:03:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id EFC65C013E for ; Fri, 23 Mar 2018 21:03:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id KBTN08RJVR8x for ; Fri, 23 Mar 2018 21:03:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 6A0B65F173 for ; Fri, 23 Mar 2018 21:03:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9FF57E0D68 for ; Fri, 23 Mar 2018 21:03:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5B960214DD for ; Fri, 23 Mar 2018 21:03:00 +0000 (UTC) Date: Fri, 23 Mar 2018 21:03:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@tephra.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TEPHRA-279) If getTransactionAwareName() throws an exception, abort() does not happen MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TEPHRA-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412058#comment-16412058 ] ASF GitHub Bot commented on TEPHRA-279: --------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/incubator-tephra/pull/69 > If getTransactionAwareName() throws an exception, abort() does not happen > ------------------------------------------------------------------------- > > Key: TEPHRA-279 > URL: https://issues.apache.org/jira/browse/TEPHRA-279 > Project: Tephra > Issue Type: Bug > Components: core > Affects Versions: 0.13.0-incubating > Reporter: Andreas Neumann > Assignee: Andreas Neumann > Priority: Major > > The problem is here in TransactionContext: > {code} > private void checkForConflicts() throws TransactionFailureException { > Collection changes = Lists.newArrayList(); > for (TransactionAware txAware : txAwares) { > try { > changes.addAll(txAware.getTxChanges()); > } catch (Throwable e) { > // ---- PROBLEM: if getTransactionAwareName() throws, abprt() is not called! > String message = String.format("Unable to retrieve changes from transaction-aware '%s' for transaction %d. ", > txAware.getTransactionAwareName(), currentTx.getTransactionId()); > LOG.warn(message, e); > abort(new TransactionFailureException(message, e)); > // abort will throw that exception > } > } > {code} > We could consider such a transaction-aware ill-behaved, but we should still make sure the transaction semantics remain correct. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)