tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Poorna Chandra (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEPHRA-286) AbstractTransactionAwareTable.ActionChange equals method always returns false
Date Wed, 21 Mar 2018 00:15:00 GMT

    [ https://issues.apache.org/jira/browse/TEPHRA-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407266#comment-16407266
] 

Poorna Chandra commented on TEPHRA-286:
---------------------------------------

[~jamestaylor] Thanks for catching this! The v3 patch looks good, but it indents code with
4 spaces. Tephra uses 2 spaces for indentation.

> AbstractTransactionAwareTable.ActionChange equals method always returns false
> -----------------------------------------------------------------------------
>
>                 Key: TEPHRA-286
>                 URL: https://issues.apache.org/jira/browse/TEPHRA-286
>             Project: Tephra
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>            Priority: Major
>             Fix For: 0.14.0-incubating
>
>         Attachments: TEPHRA-286_v1.patch, TEPHRA-286_v2.patch, TEPHRA-286_v3.patch
>
>
> The AbstractTransactionAwareTable.ActionChange class uses Objects.equals to compare byte[]
which will always return false (unless the two arrays are ==). It should be changed to use
Bytes.equals instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message