tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From poornachandra <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #67: TEPHRA-272 Add HBase 2.0 compatibility mo...
Date Tue, 09 Jan 2018 13:39:26 GMT
Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/67#discussion_r160397436
  
    --- Diff: tephra-hbase-compat-2.0/src/main/java/org/apache/tephra/hbase/SecondaryIndexTable.java
---
    @@ -0,0 +1,182 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *      http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.tephra.hbase;
    +
    +import com.google.common.base.Throwables;
    +
    +import org.apache.hadoop.hbase.Cell;
    +import org.apache.hadoop.hbase.CellUtil;
    +import org.apache.hadoop.hbase.TableName;
    +import org.apache.hadoop.hbase.client.Admin;
    +import org.apache.hadoop.hbase.client.Connection;
    +import org.apache.hadoop.hbase.client.ConnectionFactory;
    +import org.apache.hadoop.hbase.client.Get;
    +import org.apache.hadoop.hbase.client.Put;
    +import org.apache.hadoop.hbase.client.Result;
    +import org.apache.hadoop.hbase.client.ResultScanner;
    +import org.apache.hadoop.hbase.client.Scan;
    +import org.apache.hadoop.hbase.client.Table;
    +import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
    +import org.apache.hadoop.hbase.util.Bytes;
    +import org.apache.tephra.TransactionContext;
    +import org.apache.tephra.TransactionFailureException;
    +import org.apache.tephra.distributed.TransactionServiceClient;
    +
    +import java.io.Closeable;
    +import java.io.IOException;
    +import java.util.ArrayList;
    +import java.util.Collections;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.Set;
    +
    +/**
    + * A Transactional SecondaryIndexTable.
    + */
    +public class SecondaryIndexTable implements Closeable {
    +  private byte[] secondaryIndex;
    +  private TransactionAwareHTable transactionAwareHTable;
    +  private TransactionAwareHTable secondaryIndexTable;
    +  private TransactionContext transactionContext;
    +  private final TableName secondaryIndexTableName;
    +  private Connection connection;
    +  private static final byte[] secondaryIndexFamily = Bytes.toBytes("secondaryIndexFamily");
    +  private static final byte[] secondaryIndexQualifier = Bytes.toBytes('r');
    +  private static final byte[] DELIMITER  = new byte[] {0};
    +
    +  public SecondaryIndexTable(TransactionServiceClient transactionServiceClient, Table
table,
    +                             byte[] secondaryIndex) throws IOException {
    +    secondaryIndexTableName = TableName.valueOf(table.getName().getNameAsString() + ".idx");
    +    this.connection = ConnectionFactory.createConnection(table.getConfiguration());
    +    Table secondaryIndexHTable = null;
    +    try (Admin hBaseAdmin = this.connection.getAdmin()) {
    +      if (!hBaseAdmin.tableExists(secondaryIndexTableName)) {
    +        hBaseAdmin.createTable(TableDescriptorBuilder.newBuilder(secondaryIndexTableName).build());
    +      }
    +      secondaryIndexHTable = this.connection.getTable(secondaryIndexTableName);
    +    } catch (Exception e) {
    +      Throwables.propagate(e);
    --- End diff --
    
    It would be good to close the `connection` in case of exception.


---

Mime
View raw message