tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From johnament <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #63: TEPHRA-265 Fix NOTICE_BINARY for Guice an...
Date Fri, 13 Oct 2017 22:18:00 GMT
Github user johnament commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/63#discussion_r144667984
  
    --- Diff: tephra-distribution/NOTICE_BINARY ---
    @@ -6,10 +6,19 @@ The Apache Software Foundation (http://www.apache.org/).
     
     Apache Tephra - notice for binary distribution
     ==============================================
    -Apache Tephra includes Guice v3.0 and Guice Assisted Inject v3.0. Tephra
    -elects to include this software in this distribution under the Apache License.
    -You can obtain a copy of the License at:
    -http://apache.org/licenses/LICENSE-2.0
    +Apache Tephra includes Guice v3.0.
    +Google Guice - Core Library
    +Copyright 2006-2011 Google, Inc.
    +
    +This product includes software developed at
    +The Apache Software Foundation (http://www.apache.org/).
    +
    +Apache Tephra includes Guice Assisted Inject v3.0.
    +Google Guice - Extensions - AssistedInject
    +Copyright 2006-2011 Google, Inc.
    +
    +This product includes software developed at
    +The Apache Software Foundation (http://www.apache.org/).
     
     Apache Tephra includes Guava v13.0.1. Tephra elects to include this software
    --- End diff --
    
    Just because a dependency is apache licensed doesn't mean it will have a NOTICE.  NOTICE
is optional, so you shouldn't include one if none is present.


---

Mime
View raw message