Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8DE24200D19 for ; Fri, 22 Sep 2017 03:10:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8C6F21609E1; Fri, 22 Sep 2017 01:10:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D1FAA1609E4 for ; Fri, 22 Sep 2017 03:10:07 +0200 (CEST) Received: (qmail 88588 invoked by uid 500); 22 Sep 2017 01:10:07 -0000 Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tephra.incubator.apache.org Delivered-To: mailing list dev@tephra.incubator.apache.org Received: (qmail 88577 invoked by uid 99); 22 Sep 2017 01:10:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Sep 2017 01:10:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 8615818FEB3 for ; Fri, 22 Sep 2017 01:10:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id xkMS56tTrg3K for ; Fri, 22 Sep 2017 01:10:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 9CE5C60D99 for ; Fri, 22 Sep 2017 01:10:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 293F3E0288 for ; Fri, 22 Sep 2017 01:10:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5FD18241E1 for ; Fri, 22 Sep 2017 01:10:00 +0000 (UTC) Date: Fri, 22 Sep 2017 01:10:00 +0000 (UTC) From: "Poorna Chandra (JIRA)" To: dev@tephra.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Reopened] (TEPHRA-263) TTL is not strictly enforced, if there are long transactions running MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 22 Sep 2017 01:10:08 -0000 [ https://issues.apache.org/jira/browse/TEPHRA-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Poorna Chandra reopened TEPHRA-263: ----------------------------------- We found that the fix can incorrectly remove more data during compactions. Reverting the fix, and re-opening the JIRA. > TTL is not strictly enforced, if there are long transactions running > -------------------------------------------------------------------- > > Key: TEPHRA-263 > URL: https://issues.apache.org/jira/browse/TEPHRA-263 > Project: Tephra > Issue Type: Bug > Reporter: Ali Anwar > Assignee: Ali Anwar > Fix For: 0.14.0-incubating > > > The logic for filtering for TTL: > https://github.com/apache/incubator-tephra/blob/release/0.12.0-incubating/tephra-core/src/main/java/org/apache/tephra/util/TxUtils.java#L66 > It is subtracting the TTL duration from the visibility upper bound, but it should be subtracting from the current time or the current write pointer instead. Otherwise, if the TTL is 1 hour, but the visibility upper bound is 22 hours ago (due to some MR that has been in progress for 22 hours), then the TTL that is actually enforced will be 23 hours and older data will be filtered. > After the long transactions are invalidated, the TTL is then strictly enforced. -- This message was sent by Atlassian JIRA (v6.4.14#64029)