Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tephra.incubator.apache.org
Date: Wed, 13 Sep 2017 08:51:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@tephra.incubator.apache.org
Message-ID: <JIRA.13096226.1503160785000.99792.1505292660215@Atlassian.JIRA>
In-Reply-To: <JIRA.13096226.1503160785000@Atlassian.JIRA>
References: <JIRA.13096226.1503160785000@Atlassian.JIRA> <JIRA.13096226.1503160785914@jira-lw-us.apache.org>
Subject: [jira] [Commented] (TEPHRA-243) When transaction log sync is slow,
 the warning message should contain more information
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 13 Sep 2017 08:51:04 -0000


    [ https://issues.apache.org/jira/browse/TEPHRA-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164333#comment-16164333 ] 

ASF GitHub Bot commented on TEPHRA-243:
---------------------------------------

Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/53#discussion_r138559674
  
    --- Diff: tephra-core/src/main/java/org/apache/tephra/persist/AbstractTransactionLog.java ---
    @@ -48,21 +52,30 @@
       protected long timestamp;
       private volatile boolean initialized;
       private volatile boolean closed;
    +  private AtomicLong writtenUpTo = new AtomicLong();
       private AtomicLong syncedUpTo = new AtomicLong();
    -  private List<Entry> pendingWrites = Lists.newLinkedList();
    +  private Queue<Entry> pendingWrites = new ConcurrentLinkedQueue<>();
       private TransactionLogWriter writer;
     
    -  public AbstractTransactionLog(long timestamp, MetricsCollector metricsCollector) {
    +  private final AtomicLong positionBeforeAppend = new AtomicLong(0);
    --- End diff --
    
    This can be just a `long` field, right? Since it is only used by the start/stop timer method, which only gets called inside the writer sync block.


> When transaction log sync is slow, the warning message should contain more information
> --------------------------------------------------------------------------------------
>
>                 Key: TEPHRA-243
>                 URL: https://issues.apache.org/jira/browse/TEPHRA-243
>             Project: Tephra
>          Issue Type: Improvement
>    Affects Versions: 0.12.0-incubating
>            Reporter: Andreas Neumann
>            Assignee: Andreas Neumann
>             Fix For: 0.13.0-incubating
>
>
> Currently we get this message:
> {noformat}
> 2017-08-12 00:59:46,938 - INFO [TTransactionServer-rpc-857:o.a.t.p.AbstractTransactionLog@102] - Slow append to log txlog.1502517541689, took 1431 msec.
> {noformat}
> It would be more useful to know how many bytes were written, how many edits were in this sync. 


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)