tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEPHRA-240) TransactionConflictException should contain the conflicting key and client id
Date Tue, 12 Sep 2017 22:51:00 GMT

    [ https://issues.apache.org/jira/browse/TEPHRA-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163804#comment-16163804
] 

ASF GitHub Bot commented on TEPHRA-240:
---------------------------------------

Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/47#discussion_r138480498
  
    --- Diff: tephra-core/src/main/thrift/transaction.thrift ---
    @@ -73,15 +79,21 @@ service TTransactionServer {
       // TODO remove this as it was replaced with startShortWithTimeout in 0.10
       TTransaction startShortTimeout(1: i32 timeout),
       TTransaction startShortClientId(1: string clientId) throws (1: TGenericException e),
    -  TTransaction startShortWithClientIdAndTimeOut(1: string clientId, 2: i32 timeout) throws
(1:TGenericException e),
    -  TTransaction startShortWithTimeout(1: i32 timeout) throws (1:TGenericException e),
    -  TBoolean canCommitTx(1: TTransaction tx, 2: set<binary> changes) throws (1:TTransactionNotInProgressException
e),
    -  TBoolean canCommitOrThrow(1: TTransaction tx, 2: set<binary> changes) throws
(1:TTransactionNotInProgressException e,
    -                                                                                2:TGenericException
g,),
    +  TTransaction startShortWithClientIdAndTimeOut(1: string clientId, 2: i32 timeout) throws
(1: TGenericException e),
    +  TTransaction startShortWithTimeout(1: i32 timeout) throws (1: TGenericException e),
    +  // TODO remove this as it was replaced with canCommitOrThrow in 0.13
    +  TBoolean canCommitTx(1: TTransaction tx, 2: set<binary> changes) throws (1: TTransactionNotInProgressException
e),
    +  void canCommitOrThrow(1: i64 tx, 2: set<binary> changes) throws (1: TTransactionNotInProgressException
e,
    +                                                                   2: TTransactionConflictException
c,
    +                                                                   3: TGenericException
g),
    +  // TODO remove this as it was replaced with commitWithExn in 0.13
       TBoolean commitTx(1: TTransaction tx) throws (1:TTransactionNotInProgressException
e),
    +  void commitOrThrow(1: i64 txId, 2: i64 wp) throws (1: TTransactionNotInProgressException
e,
    --- End diff --
    
    I missed it yesterday, it would be good to use TransactionFailureException here too for
future-proofing.


> TransactionConflictException should contain the conflicting key and client id
> -----------------------------------------------------------------------------
>
>                 Key: TEPHRA-240
>                 URL: https://issues.apache.org/jira/browse/TEPHRA-240
>             Project: Tephra
>          Issue Type: Bug
>            Reporter: Andreas Neumann
>            Assignee: Andreas Neumann
>             Fix For: 0.13.0-incubating
>
>
> Often transaction conflicts are hard to explain. Having the conflicting key, or even
the name of the client that performed the concurrent update would greatly help debug.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message