tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anew <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #53: (TEPHRA-243) Improve logging for slow log...
Date Wed, 13 Sep 2017 06:32:25 GMT
Github user anew commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/53#discussion_r138534049
  
    --- Diff: tephra-core/src/main/java/org/apache/tephra/persist/AbstractTransactionLog.java
---
    @@ -211,26 +212,36 @@ private void sync() throws IOException {
           // prevent writer being dereferenced
    --- End diff --
    
    I am not sure why this is needed. As long as this method is running, there is a stack
frame (= a GC root) that has a reference to this, and hence to its members. Anybody know why
this is here?


---

Mime
View raw message