Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tephra.incubator.apache.org
From: anew <git@git.apache.org>
To: dev@tephra.incubator.apache.org
Reply-To: dev@tephra.incubator.apache.org
References: <git-pr-48-incubator-tephra@git.apache.org>
In-Reply-To: <git-pr-48-incubator-tephra@git.apache.org>
Subject: [GitHub] incubator-tephra pull request #48: [TEPHRA-241] Introduce a way to limit the...
Content-Type: text/plain
Message-Id: <20170831215226.8C807E08F6@git1-us-west.apache.org>
Date: Thu, 31 Aug 2017 21:52:26 +0000 (UTC)
archived-at: Thu, 31 Aug 2017 21:52:30 -0000

Github user anew commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/48#discussion_r136457929
  
    --- Diff: tephra-core/src/test/java/org/apache/tephra/TransactionManagerTest.java ---
    @@ -54,115 +54,35 @@ protected TransactionStateStorage getStateStorage() {
         return txStateStorage;
       }
     
    -  @Before
    -  public void before() {
    +  @BeforeClass
    +  public static void beforeClass() {
    +    conf = getCommonConfiguration();
         conf.setInt(TxConstants.Manager.CFG_TX_CLEANUP_INTERVAL, 0); // no cleanup thread
    -    conf.setInt(TxConstants.Manager.CFG_TX_MAX_TIMEOUT, (int) TimeUnit.DAYS.toSeconds(5)); // very long limit
         // todo should create two sets of tests, one with LocalFileTxStateStorage and one with InMemoryTxStateStorage
         txStateStorage = new InMemoryTransactionStateStorage();
         txManager = new TransactionManager
           (conf, txStateStorage, new TxMetricsCollector());
         txManager.startAndWait();
       }
     
    -  @After
    -  public void after() {
    +  @AfterClass
    +  public static void afterClass() {
         txManager.stopAndWait();
       }
     
    -  @Test
    --- End diff --
    
    this test moved to TransactionSystemTest without change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---