tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anew <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #48: [TEPHRA-241] Introduce a way to limit the...
Date Thu, 31 Aug 2017 21:51:13 GMT
GitHub user anew opened a pull request:


    [TEPHRA-241] Introduce a way to limit the size of a transaction

    - first commit introduces four new configurations for change set size limits, enforces
these limits in a new method canCommitOrThrow() (we keep canCommit() for compatibility), and
uses the new method throughout the higher level classes and tests
    - second commit refactors the transaction system test cases: Don't start a new TxManager
for each test method, have a shared common configuration across subclasses, move the checkpoint
test to the base class such that it also gets tested with Thrift
    - third commit adds a new test case for size limit validation
    Thrift changes are backward-compatible (we keep the existing methods the same), and so
are the TransactionSystemClient changes. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anew/incubator-tephra tephra-241

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #48
commit 7227bcef076ccf762b78bf299003c373e7e73814
Author: anew <anew@apache.org>
Date:   2017-08-31T21:43:32Z

    add new config properties and a new method canCommitOrThrow() that validates the size
of change sets

commit 4ad0f924c34ad4aea35443c8cd10bd81cf24eeb8
Author: anew <anew@apache.org>
Date:   2017-08-31T21:43:56Z

    refactor transaction system test

commit f3a1e786ae62f6bf05043c6fd770338361e615bc
Author: anew <anew@apache.org>
Date:   2017-08-31T21:44:32Z

    add new test for change set size validation


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message