tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEPHRA-240) TransactionConflictException should contain the conflicting key and client id
Date Thu, 17 Aug 2017 23:29:00 GMT

    [ https://issues.apache.org/jira/browse/TEPHRA-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131473#comment-16131473
] 

ASF GitHub Bot commented on TEPHRA-240:
---------------------------------------

GitHub user anew opened a pull request:

    https://github.com/apache/incubator-tephra/pull/47

    [TEPHRA-240] Include conflicting key and client id in TransactionConflictException

    - Enhances TransactionConflictException to have fields for the transaction id, the conflicting
change, and the conflicting client id
    - TransactionManager to retain the client id for change sets after the transaction has
committed
    - A configuration for whether and how long it should be retained. This is to allow disabling
this feature (and it effect on memory)
    - TransactionManager.(can)Commit now throws TrandactionConflictException instead of returning
a boolean
    - new thrift methods (and a new thrift exception). The existing thrift methods will remain
backward-compatible
    - change TransactionSystemClient and TransactionContext to use the new methods
    - new test case (and existing test case changes) for this
    - a few unrelated warnings have been removed from TransactionManager
    - a bit of test case refactoring to remove duplication of code

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anew/incubator-tephra tephra-240

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tephra/pull/47.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #47
    
----
commit 205714fdd126ab7537f9f66e6e156c9736f54646
Author: anew <anew@apache.org>
Date:   2017-08-17T23:21:52Z

    [TEPHRA-240] Include conflicting key and client id in TransactionConflictException

----


> TransactionConflictException should contain the conflicting key and client id
> -----------------------------------------------------------------------------
>
>                 Key: TEPHRA-240
>                 URL: https://issues.apache.org/jira/browse/TEPHRA-240
>             Project: Tephra
>          Issue Type: Bug
>            Reporter: Andreas Neumann
>            Assignee: Poorna Chandra
>
> Often transaction conflicts are hard to explain. Having the conflicting key, or even
the name of the client that performed the concurrent update would greatly help debug.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message