tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bijugs <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #45: [TEPHRA-236] Changes to replace deprecate...
Date Mon, 07 Aug 2017 12:21:37 GMT
Github user bijugs commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/45#discussion_r131639838
  
    --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/SecondaryIndexTable.java
---
    @@ -177,11 +173,23 @@ public void close() throws IOException {
         } catch (IOException e) {
           try {
             secondaryIndexTable.close();
    +        conn.close();
           } catch (IOException ex) {
             e.addSuppressed(e);
           }
           throw e;
         }
         secondaryIndexTable.close();
    +    conn.close();
    +  }
    +
    +  protected void finalize() throws Throwable {
    --- End diff --
    
    Was being overly cautious to not leave the connection open. Will remove it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message