tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From poornachandra <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #45: [TEPHRA-236] Changes to replace deprecate...
Date Mon, 07 Aug 2017 08:13:55 GMT
Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/45#discussion_r131594276
  
    --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/SecondaryIndexTable.java
---
    @@ -177,11 +173,23 @@ public void close() throws IOException {
         } catch (IOException e) {
           try {
             secondaryIndexTable.close();
    +        conn.close();
           } catch (IOException ex) {
             e.addSuppressed(e);
           }
           throw e;
         }
         secondaryIndexTable.close();
    +    conn.close();
    +  }
    +
    +  protected void finalize() throws Throwable {
    --- End diff --
    
    We try not to rely on `finalize()` since there is no guarantee when it will be called.
Also since we are closing the connection in the `close()` method, there is no need for finalize.
Let's remove this method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message