Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tephra.incubator.apache.org
From: bijugs <git@git.apache.org>
To: dev@tephra.incubator.apache.org
Reply-To: dev@tephra.incubator.apache.org
References: <git-pr-45-incubator-tephra@git.apache.org>
In-Reply-To: <git-pr-45-incubator-tephra@git.apache.org>
Subject: [GitHub] incubator-tephra pull request #45: [TEPHRA-236] Changes to replace deprecate...
Content-Type: text/plain
Message-Id: <20170712133509.6EC6AE96AB@git1-us-west.apache.org>
Date: Wed, 12 Jul 2017 13:35:08 +0000 (UTC)
archived-at: Wed, 12 Jul 2017 13:35:22 -0000

Github user bijugs commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/45#discussion_r126955216
  
    --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/SecondaryIndexTable.java ---
    @@ -56,17 +58,24 @@
       private static final byte[] secondaryIndexQualifier = Bytes.toBytes('r');
       private static final byte[] DELIMITER  = new byte[] {0};
     
    -  public SecondaryIndexTable(TransactionServiceClient transactionServiceClient, HTableInterface hTable,
    -                             byte[] secondaryIndex) {
    +  public SecondaryIndexTable(TransactionServiceClient transactionServiceClient, Table hTable,
    +                             byte[] secondaryIndex) throws IOException {
         secondaryIndexTableName = TableName.valueOf(hTable.getName().getNameAsString() + ".idx");
    -    HTable secondaryIndexHTable = null;
    -    try (HBaseAdmin hBaseAdmin = new HBaseAdmin(hTable.getConfiguration())) {
    +    Table secondaryIndexHTable = null;
    +    Connection conn  = null;
    +    try { 
    +      conn  = ConnectionFactory.createConnection(hTable.getConfiguration());
    +      Admin hBaseAdmin = conn.getAdmin();
           if (!hBaseAdmin.tableExists(secondaryIndexTableName)) {
             hBaseAdmin.createTable(new HTableDescriptor(secondaryIndexTableName));
           }
    -      secondaryIndexHTable = new HTable(hTable.getConfiguration(), secondaryIndexTableName);
    -    } catch (Exception e) {
    +      secondaryIndexHTable = conn.getTable(secondaryIndexTableName);
    +    } catch (Exception e) { 
           Throwables.propagate(e);
    +    } finally {
    +      if (conn != null) {
    +         conn.close();
    --- End diff --
    
    This connection is local to the constructor and gets closed when the constructor execution is complete. Looks like we don't need to take any further actions in ``close()``. Please let me know otherwise.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---