tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From poornachandra <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #45: [TEPHRA-236] Changes to replace deprecate...
Date Tue, 11 Jul 2017 20:17:38 GMT
Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/45#discussion_r126789026
  
    --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/SecondaryIndexTable.java
---
    @@ -56,17 +58,24 @@
       private static final byte[] secondaryIndexQualifier = Bytes.toBytes('r');
       private static final byte[] DELIMITER  = new byte[] {0};
     
    -  public SecondaryIndexTable(TransactionServiceClient transactionServiceClient, HTableInterface
hTable,
    -                             byte[] secondaryIndex) {
    +  public SecondaryIndexTable(TransactionServiceClient transactionServiceClient, Table
hTable,
    +                             byte[] secondaryIndex) throws IOException {
         secondaryIndexTableName = TableName.valueOf(hTable.getName().getNameAsString() +
".idx");
    -    HTable secondaryIndexHTable = null;
    -    try (HBaseAdmin hBaseAdmin = new HBaseAdmin(hTable.getConfiguration())) {
    +    Table secondaryIndexHTable = null;
    +    Connection conn  = null;
    +    try { 
    +      conn  = ConnectionFactory.createConnection(hTable.getConfiguration());
    +      Admin hBaseAdmin = conn.getAdmin();
           if (!hBaseAdmin.tableExists(secondaryIndexTableName)) {
             hBaseAdmin.createTable(new HTableDescriptor(secondaryIndexTableName));
           }
    -      secondaryIndexHTable = new HTable(hTable.getConfiguration(), secondaryIndexTableName);
    -    } catch (Exception e) {
    +      secondaryIndexHTable = conn.getTable(secondaryIndexTableName);
    +    } catch (Exception e) { 
           Throwables.propagate(e);
    +    } finally {
    +      if (conn != null) {
    +         conn.close();
    --- End diff --
    
    The connection has to be closed in the method `SecondaryIndexTable.close()` too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message