Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6DC1D200C89 for ; Sat, 20 May 2017 02:06:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6C4DE160BD4; Sat, 20 May 2017 00:06:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B459F160BD1 for ; Sat, 20 May 2017 02:06:06 +0200 (CEST) Received: (qmail 3704 invoked by uid 500); 20 May 2017 00:06:06 -0000 Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tephra.incubator.apache.org Delivered-To: mailing list dev@tephra.incubator.apache.org Received: (qmail 3692 invoked by uid 99); 20 May 2017 00:06:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 20 May 2017 00:06:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 915D2C31C1 for ; Sat, 20 May 2017 00:06:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.201 X-Spam-Level: X-Spam-Status: No, score=-99.201 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id VNUo-6Y9g7Fd for ; Sat, 20 May 2017 00:06:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C1D205F20C for ; Sat, 20 May 2017 00:06:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 51F48E036E for ; Sat, 20 May 2017 00:06:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0C23221B56 for ; Sat, 20 May 2017 00:06:04 +0000 (UTC) Date: Sat, 20 May 2017 00:06:04 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@tephra.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TEPHRA-228) Introduce client ID that can be used to track requests per client MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 20 May 2017 00:06:07 -0000 [ https://issues.apache.org/jira/browse/TEPHRA-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018189#comment-16018189 ] ASF GitHub Bot commented on TEPHRA-228: --------------------------------------- Github user gokulavasan commented on the issue: https://github.com/apache/incubator-tephra/pull/42 @poornachandra Can you please review the last commit. I have addressed your comment about TransactionContext change (deprecated old constructors and introduced a new one with the clientId) > Introduce client ID that can be used to track requests per client > ----------------------------------------------------------------- > > Key: TEPHRA-228 > URL: https://issues.apache.org/jira/browse/TEPHRA-228 > Project: Tephra > Issue Type: Improvement > Components: api, core > Reporter: Poorna Chandra > Assignee: Gokul Gunasekaran > Fix For: 0.12.0-incubating > > > Today transaction manager does not have details of what transaction belongs to which client. For instance when a there are a lot of invalid transactions generated by a client, it is not easy to say which client generated the invalid transactions. Transaction manager just logs a message saying the transaction ID was invalidated. This makes debugging very difficult since there is no easy way to map the transaction ID to a program. > Transaction APIs should allow clients to pass in client IDs for every start transaction call. Transaction manager can store this client ID as part of the transaction metadata. And when transaction manager logs messages with transaction ID, it can include the client ID in the message. -- This message was sent by Atlassian JIRA (v6.3.15#6346)