Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tephra.incubator.apache.org
Date: Thu, 18 May 2017 18:12:04 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@tephra.incubator.apache.org
Message-ID: <JIRA.13066477.1493066176000.243418.1495131124457@Atlassian.JIRA>
In-Reply-To: <JIRA.13066477.1493066176000@Atlassian.JIRA>
References: <JIRA.13066477.1493066176000@Atlassian.JIRA> <JIRA.13066477.1493066176870@jira-lw-us.apache.org>
Subject: [jira] [Commented] (TEPHRA-228) Introduce client ID that can be
 used to track requests per client
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 18 May 2017 18:12:12 -0000


    [ https://issues.apache.org/jira/browse/TEPHRA-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016186#comment-16016186 ] 

ASF GitHub Bot commented on TEPHRA-228:
---------------------------------------

Github user gokulavasan commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/42#discussion_r117316435
  
    --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
    @@ -763,15 +781,22 @@ private long getNextWritePointer() {
        * transaction moves it to the invalid list because we assume that its writes cannot be rolled back.
        */
       public Transaction startLong() {
    +    return startLong(null);
    +  }
    +
    +  /**
    +   * Starts a long transaction with a client id.
    +   */
    +  public Transaction startLong(String clientId) {
    --- End diff --
    
    If we are going to deprecate the clientId-less methods, should we allow null here?


> Introduce client ID that can be used to track requests per client
> -----------------------------------------------------------------
>
>                 Key: TEPHRA-228
>                 URL: https://issues.apache.org/jira/browse/TEPHRA-228
>             Project: Tephra
>          Issue Type: Improvement
>          Components: api, core
>            Reporter: Poorna Chandra
>            Assignee: Gokul Gunasekaran
>             Fix For: 0.12.0-incubating
>
>
> Today transaction manager does not have details of what transaction belongs to which client. For instance when a there are a lot of invalid transactions generated by a client, it is not easy to say which client generated the invalid transactions. Transaction manager just logs a message saying the transaction ID was invalidated. This makes debugging very difficult since there is no easy way to map the transaction ID to a program.
> Transaction APIs should allow clients to pass in client IDs for every start transaction call. Transaction manager can store this client ID as part of the transaction metadata. And when transaction manager logs messages with transaction ID, it can include the client ID in the message.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)