Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tephra.incubator.apache.org
From: poornachandra <git@git.apache.org>
To: dev@tephra.incubator.apache.org
Reply-To: dev@tephra.incubator.apache.org
References: <git-pr-42-incubator-tephra@git.apache.org>
In-Reply-To: <git-pr-42-incubator-tephra@git.apache.org>
Subject: [GitHub] incubator-tephra pull request #42: TEPHRA-228 Adding the ability to pass-in ...
Content-Type: text/plain
Message-Id: <20170519185813.D663DDFC8B@git1-us-west.apache.org>
Date: Fri, 19 May 2017 18:58:13 +0000 (UTC)
archived-at: Fri, 19 May 2017 18:58:18 -0000

Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/42#discussion_r117552141
  
    --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
    @@ -1378,17 +1403,32 @@ public TransactionType getTransactionType() {
         private final long expiration;
         private final InProgressType type;
         private final LongArrayList checkpointWritePointers;
    +    private final String clientId;
    --- End diff --
    
    It is okay not to add it now since we are not persisting it. Add a comment in the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---