Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tephra.incubator.apache.org
From: gokulavasan <git@git.apache.org>
To: dev@tephra.incubator.apache.org
Reply-To: dev@tephra.incubator.apache.org
References: <git-pr-42-incubator-tephra@git.apache.org>
In-Reply-To: <git-pr-42-incubator-tephra@git.apache.org>
Subject: [GitHub] incubator-tephra pull request #42: TEPHRA-228 Adding the ability to pass-in ...
Content-Type: text/plain
Message-Id: <20170518215332.D0C63DFC8B@git1-us-west.apache.org>
Date: Thu, 18 May 2017 21:53:32 +0000 (UTC)
archived-at: Thu, 18 May 2017 21:53:37 -0000

Github user gokulavasan commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/42#discussion_r117363141
  
    --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
    @@ -763,15 +781,22 @@ private long getNextWritePointer() {
        * transaction moves it to the invalid list because we assume that its writes cannot be rolled back.
        */
       public Transaction startLong() {
    +    return startLong(null);
    +  }
    +
    +  /**
    +   * Starts a long transaction with a client id.
    +   */
    +  public Transaction startLong(String clientId) {
    --- End diff --
    
    @poornachandra Sure sounds good. I will add a Precondition check for String not being null.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---