From dev-return-1205-apmail-tephra-dev-archive=tephra.apache.org@tephra.incubator.apache.org Wed May 17 23:10:06 2017 Return-Path: X-Original-To: apmail-tephra-dev-archive@minotaur.apache.org Delivered-To: apmail-tephra-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AE18B19FAF for ; Wed, 17 May 2017 23:10:06 +0000 (UTC) Received: (qmail 57914 invoked by uid 500); 17 May 2017 23:10:06 -0000 Delivered-To: apmail-tephra-dev-archive@tephra.apache.org Received: (qmail 57874 invoked by uid 500); 17 May 2017 23:10:06 -0000 Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tephra.incubator.apache.org Delivered-To: mailing list dev@tephra.incubator.apache.org Received: (qmail 57863 invoked by uid 99); 17 May 2017 23:10:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 May 2017 23:10:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 1F3D4C075A for ; Wed, 17 May 2017 23:10:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.201 X-Spam-Level: X-Spam-Status: No, score=-99.201 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id w-wwEyAzHeXT for ; Wed, 17 May 2017 23:10:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 4BED55FC84 for ; Wed, 17 May 2017 23:10:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id F4168E0D7F for ; Wed, 17 May 2017 23:10:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 37799263AA for ; Wed, 17 May 2017 23:10:04 +0000 (UTC) Date: Wed, 17 May 2017 23:10:04 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@tephra.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TEPHRA-228) Introduce client ID that can be used to track requests per client MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TEPHRA-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014910#comment-16014910 ] ASF GitHub Bot commented on TEPHRA-228: --------------------------------------- Github user poornachandra commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/42#discussion_r117129143 --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionManager.java --- @@ -763,15 +781,22 @@ private long getNextWritePointer() { * transaction moves it to the invalid list because we assume that its writes cannot be rolled back. */ public Transaction startLong() { + return startLong(null); + } + + /** + * Starts a long transaction with a client id. + */ + public Transaction startLong(String clientId) { --- End diff -- Should we throw an exception if `clientId` is null? > Introduce client ID that can be used to track requests per client > ----------------------------------------------------------------- > > Key: TEPHRA-228 > URL: https://issues.apache.org/jira/browse/TEPHRA-228 > Project: Tephra > Issue Type: Improvement > Components: api, core > Reporter: Poorna Chandra > Assignee: Gokul Gunasekaran > Fix For: 0.12.0-incubating > > > Today transaction manager does not have details of what transaction belongs to which client. For instance when a there are a lot of invalid transactions generated by a client, it is not easy to say which client generated the invalid transactions. Transaction manager just logs a message saying the transaction ID was invalidated. This makes debugging very difficult since there is no easy way to map the transaction ID to a program. > Transaction APIs should allow clients to pass in client IDs for every start transaction call. Transaction manager can store this client ID as part of the transaction metadata. And when transaction manager logs messages with transaction ID, it can include the client ID in the message. -- This message was sent by Atlassian JIRA (v6.3.15#6346)