tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEPHRA-228) Introduce client ID that can be used to track requests per client
Date Mon, 22 May 2017 20:35:04 GMT

    [ https://issues.apache.org/jira/browse/TEPHRA-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020150#comment-16020150

ASF GitHub Bot commented on TEPHRA-228:

Github user gokulavasan commented on a diff in the pull request:

    --- Diff: tephra-core/src/main/java/org/apache/tephra/runtime/TransactionDistributedModule.java
    @@ -35,13 +34,24 @@
     import org.apache.tephra.persist.TransactionStateStorage;
     import org.apache.tephra.snapshot.SnapshotCodecProvider;
    +import java.lang.management.ManagementFactory;
      * Guice bindings for running in distributed mode on a cluster.
    -final class TransactionDistributedModule extends AbstractModule {
    +final class TransactionDistributedModule extends ClientIdAwareTransactionModule {
    +  public TransactionDistributedModule() {
    +    super(ManagementFactory.getRuntimeMXBean().getName());
    --- End diff --
    @poornachandra There is no guarantee that TransactionModules().getDistributedModule()
is used to get an instance of TransactionDistributedModule. One can just create an instance
of this class.

> Introduce client ID that can be used to track requests per client
> -----------------------------------------------------------------
>                 Key: TEPHRA-228
>                 URL: https://issues.apache.org/jira/browse/TEPHRA-228
>             Project: Tephra
>          Issue Type: Improvement
>          Components: api, core
>            Reporter: Poorna Chandra
>            Assignee: Gokul Gunasekaran
>             Fix For: 0.12.0-incubating
> Today transaction manager does not have details of what transaction belongs to which
client. For instance when a there are a lot of invalid transactions generated by a client,
it is not easy to say which client generated the invalid transactions. Transaction manager
just logs a message saying the transaction ID was invalidated. This makes debugging very difficult
since there is no easy way to map the transaction ID to a program.
> Transaction APIs should allow clients to pass in client IDs for every start transaction
call. Transaction manager can store this client ID as part of the transaction metadata. And
when transaction manager logs messages with transaction ID, it can include the client ID in
the message.

This message was sent by Atlassian JIRA

View raw message