tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From poornachandra <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #42: TEPHRA-228 Adding the ability to pass-in ...
Date Mon, 22 May 2017 20:14:42 GMT
Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/42#discussion_r117834468
  
    --- Diff: tephra-core/src/main/java/org/apache/tephra/runtime/TransactionDistributedModule.java
---
    @@ -35,13 +34,24 @@
     import org.apache.tephra.persist.TransactionStateStorage;
     import org.apache.tephra.snapshot.SnapshotCodecProvider;
     
    +import java.lang.management.ManagementFactory;
    +
     /**
      * Guice bindings for running in distributed mode on a cluster.
      */
    -final class TransactionDistributedModule extends AbstractModule {
    +final class TransactionDistributedModule extends ClientIdAwareTransactionModule {
    +
    +  public TransactionDistributedModule() {
    +    super(ManagementFactory.getRuntimeMXBean().getName());
    --- End diff --
    
    This default is already defined in `TransactionModules`. Do we still need it here? 
    Same for `TransactionInMemoryModule` and `TransactionLocalModule`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message