tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From poornachandra <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #42: TEPHRA-228 Adding the ability to pass-in ...
Date Mon, 22 May 2017 20:14:42 GMT
Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/42#discussion_r117827109
  
    --- Diff: tephra-core/src/main/java/org/apache/tephra/distributed/TransactionServiceClient.java
---
    @@ -50,6 +51,7 @@
      * A tx service client
      */
     public class TransactionServiceClient implements TransactionSystemClient {
    +  public static final String CLIENT_ID = "clientId";
    --- End diff --
    
    It would be better to move this definition to `TxConstants` since this is to be used by
external programs. Also call it as `tephra.client.id` to disambiguate.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message