tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gokulavasan <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #42: TEPHRA-228 Adding the ability to pass-in ...
Date Thu, 18 May 2017 18:39:23 GMT
Github user gokulavasan commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/42#discussion_r117322759
  
    --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
    @@ -1378,17 +1403,32 @@ public TransactionType getTransactionType() {
         private final long expiration;
         private final InProgressType type;
         private final LongArrayList checkpointWritePointers;
    +    private final String clientId;
    --- End diff --
    
    Not sure if we can add it to equals/hashCode. The unit tests fail when trying to compare
the state before persistence and after recovery and won't be the same if we include clientId
in comparison. Any reason why we should definitely include it? Or should we include it and
adjust the test that does the comparison?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message