Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tephra.incubator.apache.org
From: gokulavasan <git@git.apache.org>
To: dev@tephra.incubator.apache.org
Reply-To: dev@tephra.incubator.apache.org
References: <git-pr-31-incubator-tephra@git.apache.org>
In-Reply-To: <git-pr-31-incubator-tephra@git.apache.org>
Subject: [GitHub] incubator-tephra pull request #31: (TEPHRA-214) Tool to debug the state and ...
Content-Type: text/plain
Message-Id: <20170207225204.BD62ADFBDB@git1-us-west.apache.org>
Date: Tue,  7 Feb 2017 22:52:04 +0000 (UTC)
archived-at: Tue, 07 Feb 2017 22:52:09 -0000

Github user gokulavasan commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/31#discussion_r99951182
  
    --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/HBaseTransactionPruningPlugin.java ---
    @@ -147,6 +147,7 @@ public long fetchPruneUpperBound(long time, long inactiveTransactionBound) throw
     
         // Get all the current transactional regions
         SortedSet<byte[]> transactionalRegions = getTransactionalRegions();
    +    // TODO: Ignore empty
    --- End diff --
    
    That TODO was meant for ignoring empty regions from the current transactional regions. I have removed that misleading TODO as part of the last commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---