Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tephra.incubator.apache.org
From: gokulavasan <git@git.apache.org>
To: dev@tephra.incubator.apache.org
Reply-To: dev@tephra.incubator.apache.org
References: <git-pr-32-incubator-tephra@git.apache.org>
In-Reply-To: <git-pr-32-incubator-tephra@git.apache.org>
Subject: [GitHub] incubator-tephra pull request #32: (TEPHRA-215) (TEPHRA-218) Use single thre...
Content-Type: text/plain
Message-Id: <20170207192221.3AB94DFB0E@git1-us-west.apache.org>
Date: Tue,  7 Feb 2017 19:22:21 +0000 (UTC)
archived-at: Tue, 07 Feb 2017 19:22:26 -0000

Github user gokulavasan commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/32#discussion_r99905573
  
    --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/PruneUpperBoundWriter.java ---
    @@ -18,55 +18,48 @@
     
     package org.apache.tephra.hbase.txprune;
     
    +import com.google.common.util.concurrent.AbstractIdleService;
     import org.apache.commons.logging.Log;
     import org.apache.commons.logging.LogFactory;
    -import org.apache.hadoop.hbase.TableName;
    -import org.apache.tephra.hbase.coprocessor.TransactionProcessor;
     
     import java.io.IOException;
    +import java.util.Iterator;
    +import java.util.Objects;
    +import java.util.Queue;
    +import java.util.concurrent.ConcurrentLinkedQueue;
     import java.util.concurrent.TimeUnit;
    -import java.util.concurrent.atomic.AtomicBoolean;
    -import java.util.concurrent.atomic.AtomicLong;
     
     /**
      * Thread that will write the the prune upper bound
      */
    -public class PruneUpperBoundWriter {
    -  private static final Log LOG = LogFactory.getLog(TransactionProcessor.class);
    +public class PruneUpperBoundWriter extends AbstractIdleService {
    +  private static final Log LOG = LogFactory.getLog(PruneUpperBoundWriter.class);
     
    -  private final TableName pruneStateTable;
       private final DataJanitorState dataJanitorState;
    -  private final byte[] regionName;
    -  private final String regionNameAsString;
       private final long pruneFlushInterval;
    -  private final AtomicLong pruneUpperBound;
    -  private final AtomicBoolean shouldFlush;
    +  private final Queue<PruneInfo> pruneEntries;
     
       private Thread flushThread;
       private long lastChecked;
     
    -  public PruneUpperBoundWriter(DataJanitorState dataJanitorState, TableName pruneStateTable, String regionNameAsString,
    -                               byte[] regionName, long pruneFlushInterval) {
    -    this.pruneStateTable = pruneStateTable;
    +  public PruneUpperBoundWriter(DataJanitorState dataJanitorState, long pruneFlushInterval) {
         this.dataJanitorState = dataJanitorState;
    -    this.regionName = regionName;
    -    this.regionNameAsString = regionNameAsString;
         this.pruneFlushInterval = pruneFlushInterval;
    -    this.pruneUpperBound = new AtomicLong();
    -    this.shouldFlush = new AtomicBoolean(false);
    +    this.pruneEntries = new ConcurrentLinkedQueue<>();
         startFlushThread();
       }
     
    -  public boolean isAlive() {
    -    return flushThread.isAlive();
    +  public void persistPruneEntry(byte[] regionName, long pruneUpperBound) {
    +    pruneEntries.add(new PruneInfo(regionName, pruneUpperBound));
    --- End diff --
    
    @poornachandra Should that max size be configurable?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---