Mailing-List: contact dev-help@tephra.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tephra.incubator.apache.org
From: poornachandra <git@git.apache.org>
To: dev@tephra.incubator.apache.org
Reply-To: dev@tephra.incubator.apache.org
References: <git-pr-31-incubator-tephra@git.apache.org>
In-Reply-To: <git-pr-31-incubator-tephra@git.apache.org>
Subject: [GitHub] incubator-tephra pull request #31: (TEPHRA-214) Tool to debug the state and ...
Content-Type: text/plain
Message-Id: <20170207075030.B6780DFA2A@git1-us-west.apache.org>
Date: Tue,  7 Feb 2017 07:50:30 +0000 (UTC)
archived-at: Tue, 07 Feb 2017 07:52:31 -0000

Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/31#discussion_r99760787
  
    --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/DataJanitorState.java ---
    @@ -129,17 +168,19 @@ public long getPruneUpperBoundForRegion(byte[] regionId) throws IOException {
             Result next;
             while ((next = scanner.next()) != null) {
               byte[] region = getRegionFromKey(next.getRow());
    -          if (regions.contains(region)) {
    -            byte[] timeBytes = next.getValue(FAMILY, PRUNE_UPPER_BOUND_COL);
    -            if (timeBytes != null) {
    -              long pruneUpperBoundRegion = Bytes.toLong(timeBytes);
    -              resultMap.put(region, pruneUpperBoundRegion);
    +          if (regions == null || regions.contains(region)) {
    +            Cell cell = next.getColumnLatestCell(FAMILY, PRUNE_UPPER_BOUND_COL);
    +            if (cell != null) {
    +              byte[] pruneUpperBoundBytes = CellUtil.cloneValue(cell);
    +              long timestamp = cell.getTimestamp();
    --- End diff --
    
    Also it may be okay to treat this as the compaction timestamp for now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---