tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEPHRA-216) Invalid Transaction List Pruning will not proceed if there are empty transactional tables
Date Fri, 10 Feb 2017 19:42:41 GMT

    [ https://issues.apache.org/jira/browse/TEPHRA-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861743#comment-15861743
] 

ASF GitHub Bot commented on TEPHRA-216:
---------------------------------------

Github user anew commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/34#discussion_r100603640
  
    --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/HBaseTransactionPruningPlugin.java
---
    @@ -288,23 +288,27 @@ private long computePruneUpperBound(TimeRegions timeRegions) throws
IOException
           SortedSet<byte[]> transactionalRegions = timeRegions.getRegions();
           long time = timeRegions.getTime();
     
    +      long inactiveTransactionBound = dataJanitorState.getInactiveTransactionBoundForTime(time);
    +      LOG.debug("Got inactive transaction bound {}", inactiveTransactionBound);
    +      // If inactiveTransactionBound is not recorded then that means the data is not
complete for these regions
    +      if (inactiveTransactionBound == -1) {
    +        if (LOG.isDebugEnabled()) {
    --- End diff --
    
    is this if necessary?


> Invalid Transaction List Pruning will not proceed if there are empty transactional tables
> -----------------------------------------------------------------------------------------
>
>                 Key: TEPHRA-216
>                 URL: https://issues.apache.org/jira/browse/TEPHRA-216
>             Project: Tephra
>          Issue Type: Improvement
>    Affects Versions: 0.11.0-incubating
>            Reporter: Gokul Gunasekaran
>            Assignee: Poorna Chandra
>
> Since empty table/regions might not undergo major compaction, the prune upper bound of
these regions will never have a value and thus will limit the progress of invalid list transaction
pruning.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message