tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEPHRA-215) Share PruneUpperBoundWriter across all TransactionProcessors on the same region server
Date Wed, 08 Feb 2017 11:51:42 GMT

    [ https://issues.apache.org/jira/browse/TEPHRA-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857879#comment-15857879
] 

ASF GitHub Bot commented on TEPHRA-215:
---------------------------------------

Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/32#discussion_r100043323
  
    --- Diff: tephra-hbase-compat-1.1-base/src/test/java/org/apache/tephra/hbase/txprune/InvalidListPruneTest.java
---
    @@ -334,6 +337,45 @@ public Table get() throws IOException {
         }
       }
     
    +  @Test(timeout = 60000L)
    +  public void testClusterShutdown() throws Exception {
    +    java.util.concurrent.ExecutorService executorService = Executors.newSingleThreadExecutor();
    +    try {
    +      // Create a new transaction snapshot
    +      InMemoryTransactionStateCache.setTransactionSnapshot(
    +        new TransactionSnapshot(100, 100, 100, ImmutableSet.of(50L),
    +                                ImmutableSortedMap.<Long, TransactionManager.InProgressTx>of()));
    +      // Run major compaction
    --- End diff --
    
    The comment can be changed to - `Try to create a situation where HBase shuts down when
the async prune writer thread is trying to write to the prune table on a compaction. This
will surface any deadlocks during HBase shutdown.`


> Share PruneUpperBoundWriter across all TransactionProcessors on the same region server
> --------------------------------------------------------------------------------------
>
>                 Key: TEPHRA-215
>                 URL: https://issues.apache.org/jira/browse/TEPHRA-215
>             Project: Tephra
>          Issue Type: Improvement
>    Affects Versions: 0.11.0-incubating
>            Reporter: Gokul Gunasekaran
>            Assignee: Gokul Gunasekaran
>             Fix For: 0.11.0-incubating
>
>
> Currently we start one prune upperbound writer thread per TransactionProcessor coprocessor.
Instead we should be able to share only one thread that flushes writes to the prune state
table periodically.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message