tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEPHRA-215) Share PruneUpperBoundWriter across all TransactionProcessors on the same region server
Date Wed, 08 Feb 2017 11:51:42 GMT

    [ https://issues.apache.org/jira/browse/TEPHRA-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857872#comment-15857872
] 

ASF GitHub Bot commented on TEPHRA-215:
---------------------------------------

Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/32#discussion_r100042824
  
    --- Diff: tephra-hbase-compat-1.1-base/src/test/java/org/apache/tephra/hbase/txprune/InvalidListPruneTest.java
---
    @@ -360,8 +404,18 @@ public TransactionStateCache get() {
         @Override
         public void postCompact(ObserverContext<RegionCoprocessorEnvironment> e, Store
store, StoreFile resultFile,
                                 CompactionRequest request) throws IOException {
    -      super.postCompact(e, store, resultFile, request);
    -      lastMajorCompactionTime.set(System.currentTimeMillis());
    +      synchronized (compactionLock) {
    +        super.postCompact(e, store, resultFile, request);
    +        lastMajorCompactionTime.set(System.currentTimeMillis());
    +      }
    +    }
    +
    +    @Override
    +    public void stop(CoprocessorEnvironment e) throws IOException {
    +      synchronized (stopLock) {
    +        System.out.println("*********** Stopping " + this.getClass().getName());
    --- End diff --
    
    Remove the debug println


> Share PruneUpperBoundWriter across all TransactionProcessors on the same region server
> --------------------------------------------------------------------------------------
>
>                 Key: TEPHRA-215
>                 URL: https://issues.apache.org/jira/browse/TEPHRA-215
>             Project: Tephra
>          Issue Type: Improvement
>    Affects Versions: 0.11.0-incubating
>            Reporter: Gokul Gunasekaran
>            Assignee: Gokul Gunasekaran
>             Fix For: 0.11.0-incubating
>
>
> Currently we start one prune upperbound writer thread per TransactionProcessor coprocessor.
Instead we should be able to share only one thread that flushes writes to the prune state
table periodically.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message