tephra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gokulavasan <...@git.apache.org>
Subject [GitHub] incubator-tephra pull request #34: TEPHRA-216 Handle empty transactional reg...
Date Fri, 10 Feb 2017 21:54:06 GMT
Github user gokulavasan commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/34#discussion_r100632110
  
    --- Diff: tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/HBaseTransactionPruningPlugin.java
---
    @@ -322,6 +333,28 @@ private long computePruneUpperBound(TimeRegions timeRegions) throws
IOException
         return -1;
       }
     
    +  private Map<byte[], Long> handleEmptyRegions(long inactiveTransactionBound,
    +                                               SortedSet<byte[]> transactionalRegions,
    +                                               Map<byte[], Long> pruneUpperBoundRegions)
throws IOException {
    +    long inactiveTransactionBoundTime = TxUtils.getTimestamp(inactiveTransactionBound);
    +    SortedSet<byte[]> emptyRegions =
    +      dataJanitorState.getEmptyRegionsAfterTime(inactiveTransactionBoundTime, transactionalRegions);
    +    LOG.debug("Got empty transactional regions for inactive transaction bound time {}:
{}",
    +              inactiveTransactionBoundTime, Iterables.transform(emptyRegions, TimeRegions.BYTE_ARR_TO_STRING_FN));
    +
    +    // The regions that are recorded as empty after inactiveTransactionBoundTime will
not have invalid data
    +    // for transactions started before or on inactiveTransactionBoundTime. Hence we can
consider the prune upper bound
    +    // for these empty regions as inactiveTransactionBound
    +    Map<byte[], Long> pubWithEmptyRegions = new TreeMap<>(Bytes.BYTES_COMPARATOR);
    +    pubWithEmptyRegions.putAll(pruneUpperBoundRegions);
    +    for (byte[] emptyRegion : emptyRegions) {
    +      if (!pruneUpperBoundRegions.containsKey(emptyRegion)) {
    --- End diff --
    
    Shouldn't this condition be reversed? If the region is empty, set the upper bound for
it to be ``inactiveTransactionBound`` .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message